This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
[experimental] Simple container rescheduling on node failure #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if label, ok := c.Labels[SwarmLabelNamespace+".reschedule-policy"]; ok { | ||
| reschedulePolicy = label | ||
| } | ||
|
|
||
| // parse affinities/constraints from env (ex. docker run -e affinity:container==redis -e affinity:image==nginx -e constraint:region==us-east -e constraint:storage==ssd) |
vieux
force-pushed
the
rescheduling
branch
2 times, most recently
from
ea7afd3 to
b72d27f
Compare
| case "engine_disconnect": | ||
| go w.rescheduleContainers(e.Engine) | ||
| case "die", "destroy", "kill", "oom", "start", "stop", "rename": | ||
| go w.reschedulePendingContainers() |
There was a problem hiding this comment.
Any reason this trigger whole cluster reschedule, instead of just this engine? I think there could be a lot of events for a big cluster. Isn't just checking this container enough?
vieux
force-pushed
the
rescheduling
branch
2 times, most recently
from
9352993 to
0220f36
Compare
|
@vieux we are working on the forced cleanup fix in moby/libnetwork#862. |
Signed-off-by: Andrea Luzzardi <[email protected]>
Add rescheduling integration tests. Signed-off-by: Andrea Luzzardi <[email protected]>
fix tests and keep swarm id remove duplicate on node reconnect explicit failure Signed-off-by: Victor Vieux <[email protected]>
Signed-off-by: Victor Vieux <[email protected]>
vieux
changed the title
| @@ -0,0 +1,81 @@ | |||
| # Docker Experimental Features | |||
There was a problem hiding this comment.
@vieux This looks like it shouldn't be here it is a backup file
Signed-off-by: Victor Vieux <[email protected]>
|
LGTM |
|
LGTM. |
|
LGTM |
abronan
added a commit
that referenced
this pull request
Jan 12, 2016
[experimental] Simple container rescheduling on node failure
Closed
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
[experimental] Simple container rescheduling on node failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1488 for details
When a node goes down, swarm will try to reschedule container on another machine.
Depends on moby/moby#19001 for IP stability.
Depends on #1569 for proper cleanup of old containers.