notary delete CLI command #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tempFile.Close() | ||
| defer os.Remove(tempFile.Name()) | ||
|
|
||
| // Setup certificate |
There was a problem hiding this comment.
Non-blocking nitpick - setting up the cert and adding a delegation role + target to the delegation seems to also be done by TestPurge and TestClientDelegationsInteraction and TestClientDelegationsPublishing, although this one doesn't need the key ID of the cert. I was wondering if we could factor this logic out to a helper function?
There was a problem hiding this comment.
Good idea - added a helper to generate a private key, cert, and keyID
|
Thanks for adding this so quickly @riyazdf! Couple of minor nits on tests, but otherwise LGTM! |
|
LGTM! Thanks for fixing this so fast! |
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
|
LGTM! Tests look great too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires up
DeleteTrustDatafrom the client library to anotary deletecommand, which will delete all local TUF metadata by default and additionally the remote metadata if the--remoteflag is given.Closes #710
Signed-off-by: Riyaz Faizullabhoy [email protected]