Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #234 was a breaking change #238

Closed
ianschmitz opened this issue Oct 14, 2022 · 0 comments · Fixed by #239
Closed

PR #234 was a breaking change #238

ianschmitz opened this issue Oct 14, 2022 · 0 comments · Fixed by #239

Comments

@ianschmitz
Copy link

Behaviour

Steps to reproduce this issue

Expected behaviour

The output is consistent across minor/patch releases.

Actual behaviour

The output now references context.payload.pull_request.head.sha if running within the context of a PR. This should have been considered a breaking change, as other workflows that later try to use {{ github.sha }} expecting that the image was previously tagged like so will no longer work.

Configuration

  • Repository URL (if public):
  • Build URL (if public):
# paste your YAML workflow file here and remove sensitive data

Logs

Download the log file of your build
and attach it to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant