This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Golang seccomp package #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crosbymichael
force-pushed
the
seccomp-args
branch
2 times, most recently
from
602d6d9 to
1db5f8e
Compare
crosbymichael
force-pushed
the
seccomp-args
branch
from
1db5f8e to
3574a08
Compare
|
Compilation errors. |
| @@ -0,0 +1,122 @@ | |||
| // Go package that provides seccomp ( https://www.kernel.org/doc/Documentation/prctl/seccomp_filter.txt ) support for go. | |||
There was a problem hiding this comment.
Should be like Package seccomp ...
crosbymichael
force-pushed
the
seccomp-args
branch
from
3574a08 to
eabb974
Compare
| Action: configs.Action(syscall.EPERM), | ||
| }) | ||
| _, _, err = runContainer(config, "", "/bin/sh", "-c", "sleep 2") | ||
| if err == nil { |
There was a problem hiding this comment.
Makes sense to check error text. We had test with just wrong cmd syntax for years in docker :)
crosbymichael
force-pushed
the
seccomp-args
branch
5 times, most recently
from
ca85553 to
7cfe887
Compare
| return true | ||
| }() | ||
|
|
||
| var edian edianSupport |
|
super-cool 👍 |
crosbymichael
force-pushed
the
seccomp-args
branch
from
7cfe887 to
1c65428
Compare
|
updated |
add seccomp feature which is not use third-party add multi arch surport add test case all code use golang this pr is relate to docker-archive#511 because I close it and find it can not be reopen Signed-off-by: Yang Shukui <[email protected]>
1. add args surport for seccomp
2. add CLONE_SECCOMP flag for preventing seccomp feature
Signed-off-by: Yang Shukui <[email protected]>
Signed-off-by: Yang Shukui <[email protected]>
Signed-off-by: Michael Crosby <[email protected]> Conflicts: configs/config.go container_linux.go seccomp/seccomp.go seccomp/seccomp.test
crosbymichael
force-pushed
the
seccomp-args
branch
from
1c65428 to
5edcda9
Compare
|
I tried with |
|
I am trying it now. Seems to work. We'll need to update doc and spec.md later. LGTM otherwise. |
|
Basic testing worked on Fedora 22 with busybox. |
|
@mrunalp How is it going here? Can we merge this? |
|
@LK4D4 yep. LGTM. |
This was referenced Jun 9, 2015
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of the work on @keloyang and @yangshukui in #529 and adds a pure Go package for using seccomp.
The changes in this PR are mostly around the package API and expressing constraints, all the hard work was done in the original commits, thanks!
This also adds security profile support for nsinit that uses seccomp for filtering. You can view the file
nsinit/security.goin this PR to see how the seccomp package is consumed.