-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
? About exposing Registerer & Gatherer #6
Comments
@jhorwit2 i would also like to not use the default one because other packages that we import in our project are having their metrics registered. Will your change prevent that from happening? |
@crosbymichael the changes I made make it easier to not use the default. Want me to include that (very easy)? I'll also need to tweak the handler to use |
@jhorwit2 sure, are you going to open a PR? It sounds like a good idea, just want to see the actual changes. Thanks for the help |
@crosbymichael Yup, i'll open one now. |
Right now the library is using the default registry (which is also a Gatherer). Is a goal of this library to not expose the underlying prometheus objects by wrapping them? I want to submit a PR that exposes the registerer & gatherer being utilized by the library. The gatherer is particularly useful because it enables us to do things with the metrics beyond just exposing them on
/metrics
; like sending task metrics from the daemon to managers using protobuf.You can see what I'm talking about here for the gatherer and here for registerer
The text was updated successfully, but these errors were encountered: