New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed `Result.Platforms` #22

Open

crazy-max opened this issue Feb 5, 2023 · 0 comments

Member

crazy-max commented Feb 5, 2023

Instead of a slice of strings in

go-imageinspect/types.go

Line 30 in 0c562e4

Platforms []string

It would be better to have typed platforms []ocispecs.Platform https://github.com/opencontainers/image-spec/blob/2fb996805b3734779bf9a3a84dc9a9691ad7efdd/specs-go/v1/descriptor.go#L52-L72 so we could have OSVersion, OSFeatures.

String representation could then be:

   - linux/ppc64le
   - linux/amd64
   - linux/386
   - linux/s390x
   - linux/riscv64
   - linux/arm64
   - linux/arm/v7
   - linux/arm/v6
   - windows/amd64:10.0.17763.2300
   - windows/amd64:10.0.14393.4770

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment