Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V binfmt to allow cross-building images for this architecture #4237

Closed
carlosedp opened this issue Jan 29, 2020 · 6 comments
Closed

Comments

@carlosedp
Copy link

After the merge of docker/binfmt#21, it's possible to cross-build images for RISC-V architecture.

This could be added to Docker for Mac.

@carlosedp
Copy link
Author

Any help with this @tonistiigi , @thaJeztah @tiborvass ?

@tonistiigi
Copy link
Member

I believe there was an issue with the release pipeline in docker/binfmt and the lastest image that was pushed in https://hub.docker.com/layers/docker/binfmt/a7996909642ee92942dcd6cff44b9b95f08dad64/images/sha256-7e54e474ac8998c01367f11edcbe2bbfcb38d9d8bd87defbc407edfa0fd6cca8?context=explore did not get signed properly for content trust. So if we require that, this pipeline issue needs to be figured out first @StefanScherer . If we don't care about the signature I can make a bump pr.

@carlosedp offtopic but did some wip work on multi-arch version of this image in https://github.com/tonistiigi/binfmt/blob/master/binfmt/Dockerfile https://gist.github.com/tonistiigi/3bde96a3f1a5d22b05c695d747853d59 , including riscv emulators, and emulators on riscv. Probably doesn't make sense for the for-mac defaults but good as external image.

@carlosedp
Copy link
Author

Nice! I will try to use it as my builder image.
Having this and docker/cli#2084 added to Docker would make cross-building images so much easier :)

@docker-robott
Copy link
Collaborator

Issues go stale after 90 days of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30 days of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@thaJeztah
Copy link
Member

This should now be available in Docker Desktop Edge 2.3.3.x, but feel free to comment if that doesn't work 👍

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants