-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker 1.8+ no longer needs dind #15596
Conversation
hmm weird errors... need to investigate why... |
the windows side is because i need to update those servers |
Is this still needed? https://github.com/docker/docker/blob/master/hack/dind#L14 |
Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed. IMO we should still keep the entrypoint around for a while since it'll still be needed on older Docker versions, but making it do the mounting nonsense conditionally based on whether we've already got it all mounted seems really sane. 👍 (ie, |
nice yeah On Fri, Aug 21, 2015 at 10:23 AM, Tianon Gravi [email protected]
|
Signed-off-by: Jessica Frazelle <[email protected]>
8145137
to
c48ac77
Compare
LGTM 🤘 |
(much easier to review via https://github.com/docker/docker/pull/15596/files?w=1 now) |
docker 1.8+ no longer needs dind
ping @tianon idk what to make the entrypoint tbh or if you think this is too soon ;)