Add support for blkio.weight_device #13959

Mashimiao · 2015-06-16T07:11:14Z

Signed-off-by: Ma Shimiao [email protected]

Mashimiao · 2015-06-19T08:37:39Z

ping @LK4D4, @icecrime , @jamtur01, @calavera

jessfraz · 2015-07-07T23:58:25Z

can you add an integration-cli test, other wise i see nothing wrong here

jessfraz · 2015-07-08T00:00:34Z

integration-cli/docker_cli_run_test.go

@@ -1128,6 +1128,13 @@ func (s *DockerSuite) TestRunWithBlkioInvalidWeight(c *check.C) {
 	}
 }

+func (s *DockerSuite) TestRunWithBlkioInvalidWeightDevice(c *check.C) {


oops my b i see this now

but we could use a valid one too

Hi @jfrazelle I planted to add a valid one. But it seems it's not easy to find out what block device does the janky have.

icecrime · 2015-07-08T00:01:30Z

@Mashimiao Thanks for the contrib! Please see the comments above.

thaJeztah · 2015-11-05T23:56:50Z

man/docker-create.1.md

@@ -83,6 +84,9 @@ The initial status of the container created with **docker create** is 'created'.
 **--blkio-weight**=0
   Block IO weight (relative weight) accepts a weight value between 10 and 1000.

+**--blkio-weight-device**=[]
+   Block IO weight (relative weight for device).


can you add (device:weight)?

thaJeztah · 2015-11-06T10:25:13Z

docs/reference/api/docker_remote_api_v1.22.md

@@ -392,6 +394,7 @@ Return low-level information on the container `id`
 		"HostConfig": {
 			"Binds": null,
 			"BlkioWeight": 0,
+            "BlkioWeightDevice": [{}],


Not your fault, but it looks like the rest of this example uses tabs for indentation 😞

Can you change to tabs to match the other lines? (just for this instance, because we normally use spaces) ☺️

moxiegirl · 2015-11-09T21:57:40Z

docs/reference/run.md

@@ -623,6 +623,7 @@ container:
 | `--cpuset-mems=""`         | Memory nodes (MEMs) in which to allow execution (0-3, 0,1). Only effective on NUMA systems. |


@Mashimiao Thank you for the contribution. You missed some tics in there and there are also some slightly awkward structs. Please move the note which states a limitation to the top of the section.

---> https://gist.github.com/moxiegirl/a7bc16b00dbdb0c45bac

Block IO bandwidth (Blkio) constraint

By default, all containers get the same proportion of block IO bandwidth
(blkio). This proportion is 500. To modify this proportion, change the
container's blkio weight relative to the weighting of all other running
containers using the --blkio-weight flag.

Note: The blkio weight setting is only available for direct IO. Buffered IO
is not currently supported.

The --blkio-weight flag takes a weight between 10 to 1000.
For example, the commands below create two containers with different blkio
weight:

$ docker run -ti --name c1 --blkio-weight 300 ubuntu:14.04 /bin/bash $ docker run -ti --name c2 --blkio-weight 600 ubuntu:14.04 /bin/bash

If you do block IO in the two containers at the same time, for example:

$ time dd if=/mnt/zerofile of=test.out bs=1M count=1024 oflag=direct

You'll find that the proportion of time is the same as the proportion of blkio
weights of the two containers.

The --blkio-weight-device="DEVICE_NAME:WEIGHT" flag sets a specific device
weight. The DEVICE_NAME:WEIGHT is a string containing a colon-separated device
name and weight. For example, to set /dev/sda device weight to 200:

$ docker run -it \ --blkio-weight-device "/dev/sda:200" \ ubuntu

If you specify both the --blkio-weight and --blkio-weight-device, Docker
uses the --blkio-weight as the default weight and uses --blkio-weight-device
to override with a different weight on a specific device. The following example uses a default weight of 300 and overrides this default
on /dev/sda setting with a weight of 200:

$ docker run -it \ --blkio-weight 300 \ --blkio-weight-device "/dev/sda:200" \ ubuntu

Thanks, fixed

@Mashimiao did you push your changes? I see the note is still at the bottom (havent checked other changes)

@thaJeztah sorry, I forgot to push my changes

A pfew almost thought I needed new glasses 👓 haha

erm, but I still don't see the changes?

@thaJeztah Sorry, forgot to modify. Already fixed

Signed-off-by: Ma Shimiao <[email protected]>

thaJeztah · 2015-11-11T15:30:29Z

Thanks @Mashimiao!

docs LGTM

ping @moxiegirl PTAL

moxiegirl · 2015-11-11T19:01:30Z

LGTM thank you @Mashimiao for your patience. @thaJeztah as you like sir!

thaJeztah · 2015-11-11T19:29:23Z

restarting the userns and windows builds for good measure

vdemeester · 2015-11-12T19:42:09Z

@thaJeztah it's green, merging 😉

Add support for blkio.weight_device

GordonTheTurtle added the status/0-triage label Jun 16, 2015

Mashimiao force-pushed the add-support-blkio_weight_device branch 11 times, most recently from 53cf8fc to c0109a9 Compare June 17, 2015 02:57

arthurk mentioned this pull request Jun 17, 2015

Support for build status context ashwanthkumar/gocd-build-github-pull-requests#44

Closed

calavera added status/1-design-review and removed status/0-triage labels Jun 19, 2015

Mashimiao force-pushed the add-support-blkio_weight_device branch 3 times, most recently from 5a03dc4 to 383af16 Compare July 2, 2015 00:41

jessfraz reviewed Jul 8, 2015
View reviewed changes

Mashimiao force-pushed the add-support-blkio_weight_device branch 7 times, most recently from 6cd23b8 to f51f5f1 Compare July 8, 2015 11:07

thaJeztah reviewed Nov 5, 2015
View reviewed changes

Mashimiao force-pushed the add-support-blkio_weight_device branch from f03555e to ecef677 Compare November 6, 2015 09:32

thaJeztah reviewed Nov 6, 2015
View reviewed changes

Mashimiao force-pushed the add-support-blkio_weight_device branch from ecef677 to 682f892 Compare November 9, 2015 02:59

moxiegirl reviewed Nov 9, 2015
View reviewed changes

Mashimiao force-pushed the add-support-blkio_weight_device branch 2 times, most recently from d3b8572 to 4a1a8e5 Compare November 11, 2015 01:24

Add support for blkio.weight_device

0fbfa14

Signed-off-by: Ma Shimiao <[email protected]>

Mashimiao force-pushed the add-support-blkio_weight_device branch from 4a1a8e5 to 0fbfa14 Compare November 11, 2015 15:06

thaJeztah added status/4-merge and removed status/3-docs-review labels Nov 11, 2015

vdemeester added a commit that referenced this pull request Nov 12, 2015

Merge pull request #13959 from Mashimiao/add-support-blkio_weight_device

812a1c1

Add support for blkio.weight_device

vdemeester merged commit 812a1c1 into moby:master Nov 12, 2015

thaJeztah added this to the 1.10 milestone Dec 4, 2015

thaJeztah mentioned this pull request Dec 4, 2015

docs: fix blkio-weight-device option args #18384

Merged

yunzhu-li mentioned this pull request May 24, 2016

Add support for Block IO constraints in HostConfig docker/docker-py#1066

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for blkio.weight_device #13959

Add support for blkio.weight_device #13959

Mashimiao commented Jun 16, 2015

Mashimiao commented Jun 19, 2015

jessfraz commented Jul 7, 2015

jessfraz Jul 8, 2015

jessfraz Jul 8, 2015

Mashimiao Jul 8, 2015

icecrime commented Jul 8, 2015

thaJeztah Nov 5, 2015

Mashimiao Nov 6, 2015

thaJeztah Nov 6, 2015

Mashimiao Nov 9, 2015

moxiegirl Nov 9, 2015

Mashimiao Nov 10, 2015

thaJeztah Nov 10, 2015

Mashimiao Nov 11, 2015

thaJeztah Nov 11, 2015

thaJeztah Nov 11, 2015

Mashimiao Nov 11, 2015

thaJeztah commented Nov 11, 2015

moxiegirl commented Nov 11, 2015

thaJeztah commented Nov 11, 2015

vdemeester commented Nov 12, 2015

		@@ -623,6 +623,7 @@ container:
		\| `--cpuset-mems=""` \| Memory nodes (MEMs) in which to allow execution (0-3, 0,1). Only effective on NUMA systems. \|

Add support for blkio.weight_device #13959

Add support for blkio.weight_device #13959

Conversation

Mashimiao commented Jun 16, 2015

Mashimiao commented Jun 19, 2015

jessfraz commented Jul 7, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

icecrime commented Jul 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Block IO bandwidth (Blkio) constraint

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thaJeztah commented Nov 11, 2015

moxiegirl commented Nov 11, 2015

thaJeztah commented Nov 11, 2015

vdemeester commented Nov 12, 2015