remove obsolete containers first on scale down #12272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
scale_rebuild_no_recreate
branch
from
350f257
to
64182e0
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
scale_rebuild_no_recreate
branch
from
64182e0
to
fa78cef
Compare
ndeloof
requested review from
a team and
glours
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As we scale down, always remove obsolete containers first, then highest-numbers.
Doing so
--no-recreatewill replace the obsolete ones (offering some kind of hand-managed rolling upgrade) - added test case to cover this scenarioRelated issue
fix #11781
(not mandatory) A picture of a cute animal, if possible in relation to what you did