-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add public function to generate docs and remove old files #43
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Guillaume Lours <[email protected]>
fea6905
to
7470ed4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 67.36% 64.45% -2.91%
==========================================
Files 4 4
Lines 576 602 +26
==========================================
Hits 388 388
- Misses 132 158 +26
Partials 56 56
☔ View full report in Codecov by Sentry. |
@crazy-max @thaJeztah sorry to ping you but I can't add reviewers in this repo |
👋 sorry, saw the PR yesterday, but didn't have time to comment. I'm ever-so-slightly wondering what the best approach is for these cases, although not "strongly" attached (this repository is a tool/utility and not a polished end-product, so "whatever works, even if quirky, or opinionated" is probably "fine"). Effectively, it's similar to, e.g., I guess the difference would be that My concern is somewhat (but again: it's a quirky tool, so "whatever works") that we wouldn't be able to tell if the generator "OWNS" a file just by looking at its name; I could have a manually maintained |
@crazy-max any good suggestions? (I'm not blocking this PR though if this is the best solution) |
Would have been better with a variadic opt on |
@crazy-max I created a new public function to avoid mis-usage of the original |
Since we're using the
alpha
command in Compose, we need to remove sub commands which may either be remove or promote as official commands.See docker/compose#11155 as example