-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use secret file mount #296
Conversation
Works great! Thanks! |
I'm a bit worried about the ambiguity here. Would be very surprising if a secret value would ever collide with a path. Could we somehow make it clear that the user expects the value to be a path? |
@tonistiigi My suggestions in #293 were a new action input ( |
@ngraef SGTM, |
A new input SGTM. |
2a585c8
to
92a879f
Compare
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 74.34% 74.39% +0.04%
==========================================
Files 4 4
Lines 152 164 +12
Branches 26 28 +2
==========================================
+ Hits 113 122 +9
- Misses 21 22 +1
- Partials 18 20 +2
Continue to review full report at Codecov.
|
Signed-off-by: CrazyMax <[email protected]>
92a879f
to
080cadd
Compare
@tonistiigi @ngraef |
Just tested. |
Signed-off-by: CrazyMax <[email protected]>
Fixes #293
@ngraef You can try with
crazy-max/docker-build-push-action@secret-file
.Signed-off-by: CrazyMax [email protected]