Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest upstream config to include reverted change in WordPress trunk #610

Closed
oskosk opened this issue May 25, 2021 · 2 comments
Closed

Comments

@oskosk
Copy link

oskosk commented May 25, 2021

Some days ago a change was introduced in WordPress trunk on a comment in the sample config file which could potentially break automation processes that relied on matching that comment. No WordPress release has come out yet and that change has been reverted 4 days ago, so the problem won't be there in official releases.

But some of the images built here as latest have been built 5 days ago including 16151c9#diff-9c0b10d9c6ed5948e9d256a9d509c03163e8526ce9acb925f9c4a9fcce6f8117, before the revert was merged. Thus containing the wrong comment: e.g.

/* Add any custom values between this line and the "stop editing" line. */

cc @tianon

AFAIK the current sate of :cli has the ability to break some script runs relying on the aforementioned comment

Thanks in advance!

@tianon
Copy link
Member

tianon commented May 25, 2021

See #573 (comment):

Yep, sounds like you're running into what caused WordPress/WordPress@cbcd3ff (which we've applied in 1d90641 but not quite published yet).

Given it's breaking WP-CLI, I've opened docker-library/official-images#10227 to get that comment change pushed out.

That's merged now, and fixed builds are in-queue or in-progress.

@tianon tianon closed this as completed May 25, 2021
@oskosk
Copy link
Author

oskosk commented May 25, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants