Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getenv_docker breaks setups relying on empty variable entries #574

Closed
Clorith opened this issue Mar 11, 2021 · 1 comment
Closed

getenv_docker breaks setups relying on empty variable entries #574

Clorith opened this issue Mar 11, 2021 · 1 comment

Comments

@Clorith
Copy link

Clorith commented Mar 11, 2021

The new use of getenv_docker for config entries will always fall back to the default values if the environment value is empty for any reason.

It isn't uncommon to run MySQL locally as root with no password in development and testing scenarios, so this breaks a fair bit of existing implementations.

Wondering if it might make sense to align the default values with the defaults of MySQL/MariaDB for the credentials section? (This would be root as username, and an empty string as password)? Doing so would restore any existing testing setups relying on the WordPress image running on default values.

@tianon
Copy link
Member

tianon commented Mar 23, 2021

Instead of the empty (and thus very insecure) values we had before, we opted in #577 to switch to the defaults used by the upstream installation wizard, but even in test environments, I'd suggest using an appropriately unprivileged user for MySQL with a randomly generated password, even if the password is randomly created once and then committed in the YAML or script harness running the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants