Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify #1085

Closed
yosifkit opened this issue Sep 29, 2015 · 5 comments
Closed

Simplify #1085

yosifkit opened this issue Sep 29, 2015 · 5 comments

Comments

@yosifkit
Copy link
Member

As pointed out by @pierreozoux in docker-library/owncloud#28 (comment), the process and management of Official Images is complicated.

This issue is for us to discuss possible solutions to simplify the process and/or the code involved with concrete ideas becoming proposal issues and pull requests. We can also discuss the reasoning for the current architecture decisions in the hope that we can learn from the past and create something better.

@pierreozoux
Copy link
Contributor

Can we have a codestyle for Dockerfile? My dream :) I can make a proposal if you want?

I like this kind: https://github.com/indiehosters/wordpress/blob/master/Dockerfile

@daghack
Copy link
Contributor

daghack commented Sep 30, 2015

In terms of "solutions to simplify the process and/or the code involved"", I feel like mandating a coding style is silly. There's no reason we should enforce, for example, spacing in a Dockerfile as long as it follows best practices. The maintainer should be able to use whatever style the feel most comfortable with. There's no reason we should arbitrate an arbitrary style.

@pierreozoux
Copy link
Contributor

@Moghedrin of course not for an external maintainer, but for the Dockerfile maintained by docker.

@daghack
Copy link
Contributor

daghack commented Sep 30, 2015

Most, if not all, of the official images maintained by us already follow a set coding style. Are you recommending that we change that coding style to something preferred by you?

@pierreozoux
Copy link
Contributor

@Moghedrin no :) Just having a clear codestyle :) I would have love to have a clear codestyle when I started to write my first Dockerfile, that's all.
All companies have codestyle, and I think it is cool.

But you know, just ignore my comment about the codestyle. I was just a bit overexcited maybe. And we are not discussing about the heart of the problem, just bike shedding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants