Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on --include/exclude-rr-types fields #80

Closed
saradickinson opened this issue Feb 10, 2022 · 1 comment
Closed

Improve documentation on --include/exclude-rr-types fields #80

saradickinson opened this issue Feb 10, 2022 · 1 comment

Comments

@saradickinson
Copy link
Contributor

These particular options control which RR fields are recorded into the C-DNS data for a particular message after that message is captured. They do not filter the captured messages based on the RRTYPE of the first Question in the Query, which some users might expect because the current documentation is a little ambiguous.

The corresponding --accept-opcode options do result in messages that don't meet the filter being discarded- see https://datatracker.ietf.org/doc/html/rfc8618#section-6.2.2 to see the distinction in the C-DNS specification.

Updates are needed to both the User Guide and the sample compactor file to make this behaviour clearer.

@saradickinson
Copy link
Contributor Author

Fixed in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant