Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How well does the compactor handle large DNS messages, e.g. AXFR #11

Open
banburybill opened this issue Aug 8, 2017 · 1 comment
Open

Comments

@banburybill
Copy link
Contributor

And how should it handle them?

At present I think a 300Mb AXFR will generate a few 300Mb buffers internally. This could be interesting.

@banburybill
Copy link
Contributor Author

Currently you can select to ignore AXFR and IXFR. As things stand, this will record the AXFR query, but not the response RR, because we only check and ignore RR type on second and subsequent queries.

It would be better to move the Q/RRTYPE ignore into the packet decode. That way we can skip over large data we don't want. It would mean having to retain the original *COUNT values, as decoded packets would have fewer entries than the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant