RFC: Allow to easy reference additional assets shipped with DNN javascript library

[roman-yagodin]

Description of problem

It's hard to reference additional assets shipped along with DNN javascript library package, e.g. CSS, images, fonts, non-main scripts, etc. Currently we need to re-implement (or borrow) non-public parts of DotNetNuke.Framework.JavaScriptLibraries code to do this.

Description of solution

Option 1 (partial solution)

Just make Javascript.GetHighestVersionLibrary() method public.

This will allow reference additional assets (see example below), but only from highest library version:

JavaScript.RequestRegistration ("JSLibrary");
var jsl = JavaScript.GetHighestVersionLibrary ("JSLibrary");
if (jsl != null) {
    ClientResourceManager.RegisterStyleSheet (Page, "/Resources/Libraries/JSLibrary/"
        + Globals.FormatVersion (jsl.Version, "00", 3, "_")
        + "/css/stylesheet.min.css",
        (int) FileOrder.Css.SkinCss,
        "DnnPageHeaderProvider",
        "js-library",
         jsl.Version.ToString ()
    );
}

Option 2 (more general solution)

Make the Javascript.GetHighestVersionLibrary() method public and also introduce following public methods:

public static JavaScriptLibrary GetLibrary (string jsname, Version version, SpecificVersion specific);
public static Version GetHighestVersion (string jsname);
public static Version GetVersion (string jsname, Version version, SpecificVersion specific);

[bdukes]

This looks great to me.

In addition, I'd think it would help to either be able to request a resource relative to a library, or to get the path of a library.

It could look something like this:

var jsl = JavaScript.GetHighestVersion("JSLibrary");
var path = jsl.GetAssetPath("css/stylesheet.min.css");
ClientResourceManager.RegisterStyleSheet(Page, path);

Or like this:

var jsl = JavaScript.GetHighestVersion("JSLibrary");
ClientResourceManager.RegisterStyleSheet(Page, jsl, "css/stylesheet.min.css");

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[roman-yagodin]

Please don't close!

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[sleupold]

anyone to submit a PR, @roman-yagodin ?

[roman-yagodin]

Well, maybe. Probably will take quite some time, though.

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[roman-yagodin]

Bump!

[stale]

We have detected this issue has not had any activity during the last 90 days. That could mean this issue is no longer relevant and/or nobody has found the necessary time to address the issue. We are trying to keep the list of open issues limited to those issues that are relevant to the majority and to close the ones that have become 'stale' (inactive). If no further activity is detected within the next 14 days, the issue will be closed automatically.
If new comments are are posted and/or a solution (pull request) is submitted for review that references this issue, the issue will not be closed. Closed issues can be reopened at any time in the future. Please remember those participating in this open source project are volunteers trying to help others and creating a better DNN Platform for all. Thank you for your continued involvement and contributions!

[stale]

This issue has been closed automatically due to inactivity (as mentioned 14 days ago). Feel free to re-open the issue if you believe it is still relevant.