Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help and version commands error without advent.yml #13

Closed
dnlgrv opened this issue Dec 1, 2022 · 0 comments · Fixed by #14
Closed

Help and version commands error without advent.yml #13

dnlgrv opened this issue Dec 1, 2022 · 0 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@dnlgrv
Copy link
Owner

dnlgrv commented Dec 1, 2022

Since #12 was introduced you can no longer run advent version or advent help without a config file in the current directory.

We need to extend the filter of commands that try to set Advent.root, as some of them don't require it.
@dnlgrv dnlgrv added the bug Something isn't working label Dec 1, 2022
@dnlgrv dnlgrv mentioned this issue Dec 2, 2022
Merged
@dnlgrv dnlgrv closed this as completed in #14 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix commands that don't require root being set dnlgrv/advent-rb
1 participant
@dnlgrv