Added feature: full screen functionality

[Vidhanvyrs]

hey @dnafication I have successfully implemented the functionality please review and merge it under hacktoberfest if you find it correct else ping me with the changes required
looking forward for the feedback

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
talk-timer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 0:58am

[dnafication]

Thanks for you contribution! I'll get back to you and I will be adding a prettier config. I see that the PR has updated the single quotes to double quotes.

[dnafication]

@Vidhanvyrs good work and thanks again. Would you be okay to merge the latest main to your branch and run npm run format please? Sorry about not having that in place before.

Also, feel free to work on other issue if you'd like :)

[dnafication]

Another thing. Looks like the footer does not auto hide anymore. Please fix that too 🙏🏼

[Vidhanvyrs]

Sure why not but I have one question doing so after this do I require to again do a commit and push or what? because see although I know how to solve the issues the main thing that confuses me while doing open source contribution is this like for example if somebody asks u to do some changes in the pr do the pr gets updated or a new pr is added can you please help me understand this flow thing

[Vidhanvyrs]

Another thing. Looks like the footer does not auto hide anymore. Please fix that too 🙏🏼

Oops I switched it off while testing the button so my fault will roll it back as it was

[dnafication]

Sure why not but I have one question doing so after this do I require to again do a commit and push or what? because see although I know how to solve the issues the main thing that confuses me while doing open source contribution is this like for example if somebody asks u to do some changes in the pr do the pr gets updated or a new pr is added can you please help me understand this flow thing

I generally keep my feature branch in sync with the branch I am planning to merge into. In this case you should merge main into your branch and resolve all the conflicts. You can do the following:

1. check out main branch
2. do git pull
3. check out your feature branch
4. run git merge main
5. resolve all the conflicts and then push. that will automatically reflect on the PR.

and it will not show this error if you did it right.

Please follow the steps above and push! good luck

[dnafication]

@Vidhanvyrs I have fixed the conflicts for you. Feel free to pull the latest and see if you can fix the issues of footer not auto hiding. Also, if you click escape to exit the fullscreen the icon state does not change.

[dnafication]

@Vidhanvyrs Just checking if you are planning to complete this PR?

[Vidhanvyrs]

Extremely Sorry @dnafication I am at the hospital now and going to have a medical surgery which is why I was not able to complete the task

[dnafication]

Extremely Sorry @dnafication I am at the hospital now and going to have a medical surgery which is why I was not able to complete the task

oh! I am sorry to hear that. Please take care of yourself. Don't worry about the task. It can wait. Your health is more important. Good luck with the surgery. I hope everything goes well. Take care!