Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript error when Disqus not included on the page. #7

Open
marisks opened this issue Mar 16, 2016 · 4 comments · May be fixed by #8
Open

JavaScript error when Disqus not included on the page. #7

marisks opened this issue Mar 16, 2016 · 4 comments · May be fixed by #8

Comments

@marisks
Copy link

marisks commented Mar 16, 2016

Error details:

Uncaught TypeError: Cannot read property 'appendChild' of null @ embed.js:17
m                                    @ embed.js:17
n                                     @ embed.js:17
h.toJSON                        @ embed.js:17
b.loadEmbed                  @ embed.js:18
(anonymous function)     @ embed.js:18

As mentioned on StackOwerflow it might be caused because of script added to the page where is no comments block:

<div id="disqus_thread"></div>

With Duk.EPiServer.Disqus package I cannot control that. Solution would be that Duk.EPiServer.Disqus would inclide script only if there is a disqus block on the page.

@Camzilla
Copy link

Camzilla commented Jul 11, 2016

Edit: Found pull requst!

@dmytroduk
Copy link
Owner

Could you please describe how to reproduce this problem on Episerver-based website?

@Camzilla
Copy link

@dmytroduk Creating a page without embedding discus on it.. The title of the ticket even specifies the problem.

@dawid-madzia
Copy link

@dmytroduk are you going to merge the fix? I've noticed the same problem as described here in one of the sites I'm working with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants