-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: publish ESM and .d.ts #32
Conversation
cometkim
commented
Oct 30, 2020
- Upgraded dependencies
- Fixed the macro
- Fixed publish configs to includes macro as well
- Added TypeScript declaration files
- Made it leaves Flow type definitions as comments
- Added ESM (modern target) build, resolves ES Module #25
- Upgraded all build dependencies to latest version - Babel 7 - Jest - Flow - Migrated the legacy build target to be using preset-env - ESM (modern) build using [preset-modules](https://github.com/babel/preset-modules) - Added TypeScript declaration files - Added Flow comment types instead of striping it - Fixed package manifest to publish babel macros
Published the fork as @cometlib/dedent |
Hi @cometkim would you mind opening this PR also against dedent-tabs which is a version of this project that I still actively maintain and were I keep all dependencies up to date. |
We need to manually add Also, for |
Do we have a ETA on this? We heavily rely on this fantasy library but have some problems using it in pure ESM environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of great stuff in here (package bumps! TypeScript types! yay!) but it's hard to take action on a PR that's got so many unrelated things. 🤔
I'll take on some of the discrete parts in order separately. Then will update this PR once those are in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 let's ship this!