Remove rabit dependency on public headers. #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6005 +/- ##
==========================================
+ Coverage 78.67% 79.04% +0.36%
==========================================
Files 12 12
Lines 3025 3025
==========================================
+ Hits 2380 2391 +11
+ Misses 645 634 -11
Continue to review full report at Codecov.
|
hcho3
reviewed
Aug 12, 2020
Comment on lines
-262
to
-265
| // in distributed mode, some partitions may not get any instance for a feature. Therefore | ||
| // we should set the size as zero | ||
| if (rabit::IsDistributed() && i + 1 >= offset_vec.size()) { | ||
| size = 0; |
There was a problem hiding this comment.
??? This logic is not necessary any more?
There was a problem hiding this comment.
There's a test added in https://github.com/dmlc/xgboost/pull/4045/files and I passed it. I remember fixing something similar to this by forcing passing correct number of features from jvm package. It was done with help from @wbo4958 .
hcho3
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6001 to get a clean merge.