Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to run brute-force test for JSON round-trip #5804

Merged
merged 10 commits into from
Jun 18, 2020
Merged

Add an option to run brute-force test for JSON round-trip #5804

Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a15a8ec
Add an option to run brute-force test for JSON round-trip
hcho3 Jun 17, 2020
8ed4a7a
Apply reviewer's feedback
hcho3 Jun 17, 2020
35a1c04
Remove unneeded objects
hcho3 Jun 17, 2020
b2f16f8
Parallel run.
trivialfis Jun 17, 2020
ad9f514
Max.
trivialfis Jun 17, 2020
dad2c12
Use signed 64-bit loop var, to support MSVC
hcho3 Jun 17, 2020
c149c2c
Add exhaustive test to CI
hcho3 Jun 17, 2020
c97b2c7
Run JSON test in Win build worker
hcho3 Jun 17, 2020
3584138
Revert "Run JSON test in Win build worker"
hcho3 Jun 18, 2020
f3c3feb
Revert "Add exhaustive test to CI"
hcho3 Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion tests/cpp/common/test_json.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,10 +545,32 @@ TEST(Json, RoundTrip) {
}

auto t = i;
i+= static_cast<uint32_t>(dist(&rng));
i += static_cast<uint32_t>(dist(&rng));
if (i < t) {
break;
}
}
}

TEST(Json, DISABLED_RoundTripExhaustive) {
auto test = [](uint32_t i) {
float f;
std::memcpy(&f, &i, sizeof(f));

Json jf{f};
std::string str;
Json::Dump(jf, &str);
auto loaded = Json::Load({str.c_str(), str.size()});
if (XGBOOST_EXPECT(std::isnan(f), false)) {
EXPECT_TRUE(std::isnan(get<Number const>(loaded)));
} else {
EXPECT_EQ(get<Number const>(loaded), f);
}
};
#pragma omp parallel for schedule(static)
for (uint32_t i = 0; i < std::numeric_limits<uint32_t>::max(); ++i) {
test(i);
}
test(std::numeric_limits<uint32_t>::max());
}
} // namespace xgboost