Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up dask tests. #6816

Closed
trivialfis opened this issue Mar 31, 2021 · 3 comments
Closed

Speed up dask tests. #6816

trivialfis opened this issue Mar 31, 2021 · 3 comments
Assignees

Comments

@trivialfis
Copy link
Member

microsoft/LightGBM#4088 (comment)

@jmoralez
Copy link
Contributor

jmoralez commented Jun 2, 2021

Hi. I'd be happy to give this a go, just have a couple of questions on the scope.

  1. Should this target only the tests that take in a client fixture or every test that builds a cluster?
  2. The main component is creating a cluster fixture that lives throughout the tests. What should the client be?
    • A fixture that uses the cluster fixture.
    • Define client = Client(cluster) in every test.
    • Use the with Client(cluster) as client context manager in every test.
    • Something else

@trivialfis
Copy link
Member Author

trivialfis commented Jun 2, 2021

I'd be happy to give this a go,

Thank you for investigating this!

The main component is creating a cluster fixture that lives throughout the tests. What should the client be

I prefer with Client() as client to client = Client(). But a client fixture seems to be much simpler if it works, also it avoids running out of file descriptors. So out of the 4 options you have provided, my preference is 1 > 3 > 2. WDYT?

@trivialfis
Copy link
Member Author

Closing since the bottleneck is hypothesis tests. Thanks for the PR @jmoralez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants