Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Clean up ci_build.sh wrapper script for legibility and clarity #6306

Closed
Tracked by #10205
hcho3 opened this issue Oct 28, 2020 · 1 comment · Fixed by #11001
Closed
Tracked by #10205

[CI] Clean up ci_build.sh wrapper script for legibility and clarity #6306

hcho3 opened this issue Oct 28, 2020 · 1 comment · Fixed by #11001
Assignees

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Oct 28, 2020

The tests/ci_build/ci_build.sh script used to be a small wrapper that ran a given command inside a Docker image. Over time, the wrapper script has become highly complex. I recently made a mistake that increased the number of times Docker images were re-built from scratch (#6305), and that one-line mistake cost us dearly, burning precious CI budget ~1.5x faster.

The wrapper script must be cleaned up for legibility and clarity.

@hcho3 hcho3 self-assigned this Oct 28, 2020
@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 28, 2020

Suggestion from @trivialfis: Use Python instead of Bash, for robust manipulation of strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant