Add proxy support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds proxy support to the tool when it downloads dependencies. The ureq library proxy supports the http, socks4, socks4a, and socks5 protocols. We take the configuration through the `PROXY` env variable. It is intentionally different than the standard HTTP_PROXY because I do not believe the configuration works exactly the same. The ureq library supports configuration in the format `<protocol>://<user>:<password>@<host>:port`. The binding-tool CLI will read the `PROXY` env variable and pass that through to ureq. In addition, binding-tool use rustls, and [rustls-native-certs](https://github.com/rustls/rustls-native-certs). This reads TLS certificates from the local system store, which means if you need to add or trust additional certificates you can just add them to your OS and the tool will pick them up automatically. If you do not or cannot add the certificate to the system store, you may set `SSL_CERT_FILE` and point it to a PEM encoded CA certs file which will be trusted instead. Signed-off-by: Daniel Mikusa <[email protected]>
Signed-off-by: Daniel Mikusa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proxy support to the tool when it downloads dependencies. The ureq library proxy supports the http, socks4, socks4a, and socks5 protocols. We take the configuration through the
PROXYenv variable. It is intentionally different than the standard HTTP_PROXY because I do not believe the configuration works exactly the same. The ureq library supports configuration in the format<protocol>://<user>:<password>@<host>:port. The binding-tool CLI will read thePROXYenv variable and pass that through to ureq.In addition, binding-tool use rustls, and rustls-native-certs. This reads TLS certificates from the local system store, which means if you need to add or trust additional certificates you can just add them to your OS and the tool will pick them up automatically. If you do not or cannot add the certificate to the system store, you may set
SSL_CERT_FILEand point it to a PEM encoded CA certs file which will be trusted instead.Resolves #20
Signed-off-by: Daniel Mikusa [email protected]