Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated URLs in calc.genoprob.R #7

Open
penyuan opened this issue May 5, 2024 · 2 comments
Open

Outdated URLs in calc.genoprob.R #7

penyuan opened this issue May 5, 2024 · 2 comments

Comments

@penyuan
Copy link

penyuan commented May 5, 2024

Hello,

When using the function calc.genoprob(), it tries to retrieve data from ftp.jax.org, such as in lines 541-550 in calc.genoprob.R:

  } else if(array == "gigamuga") {
    snpfile  = "ftp://ftp.jax.org/MUGA/GM_snps.Rdata"
    sexfile  = "ftp://ftp.jax.org/MUGA/GM_sex.Rdata"
    codefile = "ftp://ftp.jax.org/MUGA/GM_code.Rdata"
    xfile    = "ftp://ftp.jax.org/MUGA/GM_x.Rdata"
    yfile    = "ftp://ftp.jax.org/MUGA/GM_y.Rdata"
    genofile = "ftp://ftp.jax.org/MUGA/GM_geno.Rdata"
    if(sampletype == "HS") { 
      codefile = "ftp://ftp.jax.org/MUGA/GM_hs_code.Rdata"
    } # if(sampletype == "HS")

In this example, ftp://ftp.jax.org/MUGA/GM_snps.Rdata no longer resolves because the file GM_snps.Rdata no longer exists.

There is a README.txt in that path which points to:

https://www.jax.org/research-and-faculty/genetic-diversity-initiative/tools-data/diversity-outbred-reference-data

It's unclear how the data within GM_snps.Rdata was structured, so even if I download the newer data files at the URL above, I don't know how to make it work with DOQTL.

Can the developers @dmgatti, @dtenenba, @hpages, @mrjc42, @vobencha et al. please advise on how to fix this?

Thank you!

@hpages
Copy link
Contributor

hpages commented May 7, 2024

@penyuan Not sure why you are tagging me here. I don't remember being involved in the developement of the DOQTL package and I don't see my name in its DESCRIPTION file either. It seems that at some point the package was part of Bioconductor but it's been removed about 5 years ago (with BioC 3.10). So tagging the current maintainer (@dmgatti) should be enough. Thanks!

@penyuan
Copy link
Author

penyuan commented May 7, 2024

Thank you for your response @hpages and the explanation. I wasn't sure who the main person is, so I tagged everyone listed as a "Contributor" to this repository. Sorry to bother you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants