You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comment mode current does not properly render reference links.
A interesting complication: the links are only identified if the reference is valid (the commit/issue/pull exists). It will only be possible to get the correct preview by making calls out to Github to validate references.
So: should we try and implement this with the external dependency? Or keep the preview fully local and leave ignoring reference links as a known issue?
The text was updated successfully, but these errors were encountered:
Reckon this has been open long enough... I'm ready to make the call here: not rendering reference links so we can remain fully local (and hence not subject to the whims of a network dependency) is the correct trade off for this tool. Closing this as won't fix.
Comment mode current does not properly render reference links.
A interesting complication: the links are only identified if the reference is valid (the commit/issue/pull exists). It will only be possible to get the correct preview by making calls out to Github to validate references.
So: should we try and implement this with the external dependency? Or keep the preview fully local and leave ignoring reference links as a known issue?
The text was updated successfully, but these errors were encountered: