Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference links in comment mode #17

Closed
dmarcotte opened this issue Dec 31, 2013 · 1 comment
Closed

Reference links in comment mode #17

dmarcotte opened this issue Dec 31, 2013 · 1 comment

Comments

@dmarcotte
Copy link
Owner

Comment mode current does not properly render reference links.

A interesting complication: the links are only identified if the reference is valid (the commit/issue/pull exists). It will only be possible to get the correct preview by making calls out to Github to validate references.

So: should we try and implement this with the external dependency? Or keep the preview fully local and leave ignoring reference links as a known issue?

@dmarcotte
Copy link
Owner Author

Reckon this has been open long enough... I'm ready to make the call here: not rendering reference links so we can remain fully local (and hence not subject to the whims of a network dependency) is the correct trade off for this tool. Closing this as won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant