Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns parser: invalid dnstap operation with Dynamic Update #887

Closed
dmachard opened this issue Nov 30, 2024 · 0 comments · Fixed by #889
Closed

dns parser: invalid dnstap operation with Dynamic Update #887

dmachard opened this issue Nov 30, 2024 · 0 comments · Fixed by #889
Labels
bug Something isn't working

Comments

@dmachard
Copy link
Owner

Describe the bug

Invalid condition

	if dm.DNS.Opcode == 5 && header.Qr == 1 {
		dm.DNSTap.Operation = "UPDATE_QUERY"
	}
	if dm.DNS.Opcode == 5 && header.Qr == 0 {
		dm.DNSTap.Operation = "UPDATE_RESPONSE"
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: properly set DNStap operation for DNS update based on QR flag dmachard/DNS-collector
1 participant
@dmachard