Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus stats on ops per second per pipeline #512

Closed
johnhtodd opened this issue Dec 15, 2023 · 1 comment · Fixed by #724
Closed

Prometheus stats on ops per second per pipeline #512

johnhtodd opened this issue Dec 15, 2023 · 1 comment · Fixed by #724

Comments

@johnhtodd
Copy link

Is your feature request related to a problem? Please describe.
There is a general counter (per stream) of "dnscollector_throughput_ops" and "dnscollector_throughput_ops_max". This may not make sense in a pipeline model and is too broad to capture meaningful data that is useful for diagnosing how flows are operating within go-dnscollector, and it would be very helpful to understand what the throughput was per pipeline stanza.

Describe the solution you'd like
Using the config file from #510 this is what perhaps the sections would look like:

dnscollector_throughput_ops_max{pipeline="all-data"} 3395
dnscollector_throughput_ops{pipeline="all-data"} 1943
dnscollector_throughput_ops_max{pipeline="apple-only"} 5
dnscollector_throughput_ops{pipeline="apple-only"} 2
dnscollector_throughput_ops_max{pipeline="outputfile"} 3390
dnscollector_throughput_ops{pipeline="outputfile"} 1934
dnscollector_throughput_ops_max{pipeline="dnsdist-receiver-from-prod-machines"} 3395
dnscollector_throughput_ops{pipeline="dnsdist-receiver-from-prod-machines"} 1943

Describe alternatives you've considered
No other alternatives seem viable.

@dmachard dmachard added this to the v0.46.0 milestone Jun 11, 2024
@dmachard dmachard mentioned this issue Jun 11, 2024
11 tasks
@dmachard
Copy link
Owner

It will be implemented in next release with global prometheus metrics. More details on PR #724

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants