-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepares for nested references #1774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for primary keys
…cyclic deps with dest capabilities
… if strategy not explicit
…for loading, makes verify_schema explicit method to be called by load, simplifies methods to prepare tables
rudolfix
added
ci full
run the full load tests on pr
breaking
This issue introduces breaking change
labels
Aug 31, 2024
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
force-pushed
the
feat/prepares-for-nested-references
branch
from
September 1, 2024 16:13
9111fa2
to
07b7ad9
Compare
rudolfix
added
the
sprint
Marks group of tasks with core team focus at this moment
label
Sep 2, 2024
rudolfix
force-pushed
the
feat/prepares-for-nested-references
branch
from
September 9, 2024 09:00
1a57a19
to
0508b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
towards #1713
PreparedTableSchema
which is required by all Job Clients to make sure prepared schema are used (typechecker now ensures that). Also slight changes to interfaces in reference so it is clear which type of schema is usedverify_schema
must be called explicitlyprepare_load_table
does not need as_staging flag. it was anyway not used consistently. and was needed only to generate SQL on Athenadlt
linkingis_nested_table
is used to tell if table is nested. nested table has aparent
hint. which is used only for this