Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql_database: integrates sql database source (Feat/1671) #1767

Merged
merged 10 commits into from
Sep 3, 2024
Merged

sql_database: integrates sql database source (Feat/1671) #1767

merged 10 commits into from
Sep 3, 2024

Conversation

willi-mueller
Copy link
Collaborator

@willi-mueller willi-mueller commented Aug 29, 2024 •
edited
Loading

Description

  • adds the implementation
  • adds tests run locally on PostgreSQL & duckdb into tests/sources
  • extracts tests run on all destinations into tests/load/sources
  • formats code and imports
  • corrects example PostgreSQL connection string for the test suite (postgres:// -> postgresql://)

Related Issues

TODO before merge

  • Decide how to proceed with sqlalchemy incompatibility. Our test suite requires 2.0 but airflow requires <2.0
  • check if postgresql connection secret needs to be adapted on CI
  • rebase on latest changes from devel branch

@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit ecabd84
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66d2060f7275c2000782715b

@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label Sep 2, 2024
@willi-mueller willi-mueller changed the base branch from devel to feat/1484-integrate-rest-api-generic-source-into-dlt-core September 2, 2024 11:14
@willi-mueller willi-mueller force-pushed the feat/1484-integrate-rest-api-generic-source-into-dlt-core branch 6 times, most recently from e7a23c2 to 0328be6 Compare September 2, 2024 14:03
@willi-mueller willi-mueller force-pushed the feat/1671-moves-sql_database-source branch 2 times, most recently from 21d54b0 to cd5251c Compare September 2, 2024 15:14
@willi-mueller willi-mueller force-pushed the feat/1671-moves-sql_database-source branch from cd5251c to d8f9005 Compare September 2, 2024 15:22
@sh-rp sh-rp marked this pull request as ready for review September 3, 2024 08:53
@sh-rp sh-rp merged commit 47802fd into feat/1484-integrate-rest-api-generic-source-into-dlt-core Sep 3, 2024
@sh-rp sh-rp deleted the feat/1671-moves-sql_database-source branch September 3, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sprint Marks group of tasks with core team focus at this moment
Projects
dlt core library
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move sql_database source from verified-sources to dlt core
3 participants
@willi-mueller @sh-rp @rudolfix