Feat/1711 create with not exists dlt tables #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
force-pushed
the
feat/1711-create-with-not-exists-dlt-tables
branch
from
0c19c0a to
7f1f76f
Compare
VioletM
previously approved these changes
Aug 26, 2024
| @@ -76,6 +76,7 @@ class DestinationCapabilitiesContext(ContainerInjectableContext): | |||
| # use naming convention in the schema | |||
| naming_convention: TNamingConventionReferenceArg = None | |||
| alter_add_multi_column: bool = True | |||
| create_table_not_exists: bool = True | |||
There was a problem hiding this comment.
I suggest to rename it that it's clear it for _dlt tables:
For ex, create_dlt_table_if_not_exists
There was a problem hiding this comment.
this is in destination caps. but I will rename it to make clear what it means
VioletM
previously approved these changes
Aug 26, 2024
rudolfix
force-pushed
the
feat/1711-create-with-not-exists-dlt-tables
branch
from
bcdd8c8 to
40b9943
Compare
willi-mueller
pushed a commit
that referenced
this pull request
Sep 2, 2024
* uses normalized column names when linking tables in relational * destination cap if create table if not exits supported * generates IF NOT EXISTS for dlt tables * adds logging for terminal and retry exception in run_managed of load job * passes schema update to be collected in trace in filesystem * fixes job log exception message
willi-mueller
pushed a commit
that referenced
this pull request
Sep 2, 2024
* uses normalized column names when linking tables in relational * destination cap if create table if not exits supported * generates IF NOT EXISTS for dlt tables * adds logging for terminal and retry exception in run_managed of load job * passes schema update to be collected in trace in filesystem * fixes job log exception message
willi-mueller
pushed a commit
that referenced
this pull request
Sep 2, 2024
* uses normalized column names when linking tables in relational * destination cap if create table if not exits supported * generates IF NOT EXISTS for dlt tables * adds logging for terminal and retry exception in run_managed of load job * passes schema update to be collected in trace in filesystem * fixes job log exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1711
NOTE: this will prevent race conditions only if CREATE TABLE IF NOT EXISTS is atomic. ie. on postgres it is not if table contains partitions: https://stackoverflow.com/questions/77486178/how-to-prevent-create-table-if-not-exists-fail-with-duplicate-table
still the chances of a race are way smaller
also fixes two minor issues, see commit list below