Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path tests Windows compatible #1384

Merged
merged 2 commits into from
May 20, 2024
Merged

Make path tests Windows compatible #1384

merged 2 commits into from
May 20, 2024

Conversation

jorritsandbrink
Copy link
Collaborator

@jorritsandbrink jorritsandbrink commented May 18, 2024 •
edited
Loading

Description

Some filesystem tests were failing with the file protocol on Windows due to string path formatting differences:

AssertionError: assert {'C:/Users/jo...3d3615.jsonl'} == {'C:\\Users\\...3d3615.jsonl'}

Fixed by changed string comparisons to Path object comparisons.

@jorritsandbrink jorritsandbrink added the bug Something isn't working label May 18, 2024
@jorritsandbrink jorritsandbrink self-assigned this May 18, 2024
@netlify Netlify
Copy link

netlify bot commented May 18, 2024 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 403f129
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6648a78953ff47000882fbb1

@jorritsandbrink jorritsandbrink requested a review from rudolfix May 18, 2024 13:18
rudolfix
rudolfix approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! we need to run some of our destination-specific tests on windows.

@rudolfix rudolfix merged commit 7a99633 into devel May 20, 2024
48 of 50 checks passed
@rudolfix rudolfix deleted the make-path-tests-windows-compatible branch May 20, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

Assignees

@jorritsandbrink jorritsandbrink

Labels
bug Something isn't working
Projects
dlt core library
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorritsandbrink @rudolfix