-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes filesystem dest on windows #1335
Conversation
✅ Deploy Preview for dlt-hub-docs canceled.
|
fc718d5
to
9f99445
Compare
LGTM, the new test is failing on mac and ubuntu now, works for windows though :D |
One note, not directly related: maybe we should organize the tests slightly differently. In the test-common workflow we now are listing tests and folders behind pytest commands. This is prone to us adding tests that might not be run on CI in the end or might be run on the wrong platform. Maybe we should reorganize them just a bit at some point to remove complexity. |
right! this structure does the following:
we could reorganize the folders or mark the tests. that still may cause problems so maybe we should use marks to exclude tests (not marked tests are run everywhere) |
9f99445
to
aca319b
Compare
Description
filesystem
destination was not working well with local windows path. we have more and more windows users so this needs ot be corrected.