Fix add_limit wrapper for async generators #1310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sultaniman
commented
May 2, 2024
| if i is not None: | ||
| count += 1 | ||
| # async gen yields awaitable so we must count one awaitable more | ||
| # so the previous one is evaluated and yielded. | ||
| # new awaitable will be cancelled | ||
| if count == max_items + int(is_async_gen): | ||
| return | ||
| yield i |
There was a problem hiding this comment.
we need to yield only after if section
sultaniman
changed the title
sultaniman
changed the title
sultaniman
force-pushed
the
fix/issue-1213-add-limit-overrun
branch
2 times, most recently
from
769874a to
33b5af6
Compare
sultaniman
changed the title
sultaniman
commented
May 7, 2024
| while True: | ||
| if should_stop: | ||
| break | ||
| yield loop.run_until_complete(gen.__anext__()) # type: ignore[arg-type] |
There was a problem hiding this comment.
I used eventloop because with the old implementation it has been complaining about not awaited generator when resource combined with .add_limit
tests/extract/test_sources.py::test_add_limit_async
/[...]/dlt/dlt/extract/pipe_iterator.py:275: RuntimeWarning: coroutine 'wrap_async_iterator.<locals>.run' was never awaited
pipe_item = next(gen)
Enable tracemalloc to get traceback where the object was allocated.
See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
sultaniman
force-pushed
the
fix/issue-1213-add-limit-overrun
branch
from
33b5af6 to
8e7fcd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address #1213