Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the RSS feed. #224

Open
dlemmermann opened this issue Jun 9, 2023 · 4 comments
Open

Integrate the RSS feed. #224

dlemmermann opened this issue Jun 9, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dlemmermann
Copy link
Collaborator

There is now a method provided by Frank Delporte to generate an RSS feed in the DataRepository2 class. The method generates a String. Maybe that needs to be saved to a file periodically, maybe we can always create it on-the-fly.

There is an RSS button in the LinksOfTheWeekHeader. That one needs to point to the feed.

@FDelporte
Copy link
Collaborator

I propose to change this link to

LinkUtil.setLink(rssImageView, "/links/rss/lotw");

That way we can others if we want to later...

@dlemmermann dlemmermann added this to the Version 2 milestone Jul 4, 2023
@dlemmermann dlemmermann modified the milestones: Version 2, Version 1 Jul 21, 2023
@dlemmermann dlemmermann modified the milestones: Version 1, Version 2 Aug 18, 2023
@valnaumov
Copy link

@dlemmermann where exactly can I find the RSS link? There's no mention of it in page sources (in https://www.jfx-central.com/links), I could not find it using Google either.

@FDelporte
Copy link
Collaborator

@FlorianKirmaier do we have a method to create a Response based on a String instead of one.jpro.platform.routing.View?

As the RSS String generation is available, we should be able to simply replace https://github.com/dlsc-software-consulting-gmbh/jfxcentral2/blob/develop/app/src/main/java/com/dlsc/jfxcentral2/app/JFXCentral2App.java#L282

Now:

.and(Route.get("/links/rss", r -> Response.view(new LinksOfTheWeekPage(size)))) // TODO: how to return raw data?

Should be replaced with:

.and(Route.get("/rss/lotw", r -> Response.view(RSSManager.createRSS())))

If this works, we could extend createRSS to generate feeds for links, components, tutorials, etc.

@FlorianKirmaier
Copy link
Collaborator

Hi everyone,
Finally found time to implement the missing feature for JPro (Adding custom HTTP handlers, to create simple responses)
And created a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants