Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getService doesn't filter unhealthy services #26

Open
sjoerdmulder opened this issue Jul 2, 2018 · 1 comment
Open

getService doesn't filter unhealthy services #26

sjoerdmulder opened this issue Jul 2, 2018 · 1 comment

Comments

@sjoerdmulder
Copy link
Contributor

Currently it seems that the ConsulHttpClient.getService method uses the Catalog https://www.consul.io/api/catalog.html#list-nodes-for-service to get all the endpoints for a service; but if a certain endpoint is considered unhealthy (for example since the consul agent is in failed mode due to network partition the client doesn't excluded it from the available nodes.

Maybe it's better to use the Health https://www.consul.io/api/health.html#list-nodes-for-service for this?
@sjoerdmulder
Copy link
Contributor Author

FYI, we have added support ourselfs in the fork here:
crobox@d0e041d
thanks to @ecyshor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjoerdmulder