Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Trailing Commas in dub.json #415

Closed
nordlow opened this issue Sep 7, 2014 · 4 comments
Closed

Disallow Trailing Commas in dub.json #415

nordlow opened this issue Sep 7, 2014 · 4 comments

Comments

@nordlow
Copy link
Contributor

nordlow commented Sep 7, 2014

As trailing commas are not accepted by the standard then maybe DUB shouldn't accept it either:

https://stackoverflow.com/questions/201782/can-you-use-a-trailing-comma-in-a-json-object

This can be confusing to D newcomers who want to use Emacs for their D development. The error occurs in Emacs' standard library so its very hard to understand what is wrong.

See also discussion at atilaneves/flycheck-dmd-dub#5

@nordlow nordlow changed the title DUB Shouldn't Allow Trailing Commas in dub.sjon DUB Shouldn't Allow Trailing Commas in dub.json Sep 7, 2014
@nordlow nordlow changed the title DUB Shouldn't Allow Trailing Commas in dub.json DUB Should Disallow Trailing Commas in dub.json Sep 7, 2014
@nordlow nordlow changed the title DUB Should Disallow Trailing Commas in dub.json Disallow Trailing Commas in dub.json Sep 7, 2014
@p0nce
Copy link
Contributor

p0nce commented Oct 5, 2014

I agree. As practical as trailing commas are, JSON + trailing commas is not exactly JSON.

@s-ludwig
Copy link
Member

s-ludwig commented Oct 5, 2014

Agreed, it should go through a regular deprecation phase and first warn about it for maybe a year or two, so that existing packages don't get broken.

@nordlow
Copy link
Contributor Author

nordlow commented Oct 5, 2014

Great. Thanks, for now.

@wilzbach
Copy link
Member

Closing this as a duplicate of #1205 (while GitHub allows to mark this, I don't see any reason in keeping two issues open for the same goal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants