-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow Trailing Commas in dub.json #415
Comments
nordlow
changed the title
DUB Shouldn't Allow Trailing Commas in dub.sjon
DUB Shouldn't Allow Trailing Commas in dub.json
Sep 7, 2014
nordlow
changed the title
DUB Shouldn't Allow Trailing Commas in dub.json
DUB Should Disallow Trailing Commas in dub.json
Sep 7, 2014
nordlow
changed the title
DUB Should Disallow Trailing Commas in dub.json
Disallow Trailing Commas in dub.json
Sep 7, 2014
I agree. As practical as trailing commas are, JSON + trailing commas is not exactly JSON. |
Agreed, it should go through a regular deprecation phase and first warn about it for maybe a year or two, so that existing packages don't get broken. |
Great. Thanks, for now. |
Closing this as a duplicate of #1205 (while GitHub allows to mark this, I don't see any reason in keeping two issues open for the same goal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As trailing commas are not accepted by the standard then maybe DUB shouldn't accept it either:
https://stackoverflow.com/questions/201782/can-you-use-a-trailing-comma-in-a-json-object
This can be confusing to D newcomers who want to use Emacs for their D development. The error occurs in Emacs' standard library so its very hard to understand what is wrong.
See also discussion at atilaneves/flycheck-dmd-dub#5
The text was updated successfully, but these errors were encountered: