Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporates reviewer feedback of 2.0.0 RC2 #285

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Incorporates reviewer feedback of 2.0.0 RC2 #285

merged 3 commits into from
Nov 22, 2023

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Nov 22, 2023

What's in the PR

  • Add the log4j2.xml only for fat jars, which aren't deployed to mvn central anyway
  • Fix some warning related to the sweble shade
  • Move some config samples to README

@rzo1 rzo1 requested review from reckart and mawiesne November 22, 2023 06:50
mawiesne
mawiesne approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @rzo1

@mawiesne mawiesne added this to the 2.0.0 milestone Nov 22, 2023
@mawiesne mawiesne merged commit 4ab7b9d into master Nov 22, 2023
@mawiesne mawiesne deleted the rel-2.0.0-comments branch November 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mawiesne mawiesne mawiesne approved these changes

@reckart reckart Awaiting requested review from reckart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rzo1 @mawiesne