Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#269 Modernize handling of java.sql resources towards try-with-resources #270

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 4, 2023

  • removes java.sql boilerplate code from WikipediaTemplateInfo and RevisionApi
  • cures some JavaDoc issues / typos along the path

What's in the PR

How to test manually

  • mvn clean test

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- removes java.sql boilerplate code from `WikipediaTemplateInfo` and `RevisionApi`
- cures some JavaDoc issues / typos along the path
@mawiesne mawiesne requested review from reckart and rzo1 November 4, 2023 08:47
@mawiesne mawiesne self-assigned this Nov 4, 2023
@mawiesne mawiesne added this to the 2.0.0 milestone Nov 4, 2023
@mawiesne mawiesne merged commit f4beb80 into master Nov 5, 2023
@mawiesne mawiesne deleted the #269-modernize-handling-of-java.sql-resources-towards-try-with-resources branch November 5, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants