Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#165 - Switch to "org.dkpro" style #234

Merged
merged 1 commit into from
Oct 20, 2023
Merged

#165 - Switch to "org.dkpro" style #234

merged 1 commit into from
Oct 20, 2023

Conversation

mawiesne
Copy link
Contributor

Change

  • relocates groupId to org.dkpro.jwpl
  • relocates artifacts/modules to dkpro-jwpl-XXX
  • moves src and test sources to new package namespace org.dkpro.jwpl
  • adapts Spring's config / context files accordingly
  • modernizes and fixes some (previously) broken javadoc
  • repairs some inconsistent packages names in various files

@mawiesne mawiesne requested review from rzo1 and reckart October 19, 2023 19:58
@mawiesne mawiesne added this to the 2.0.0 milestone Oct 19, 2023
@reckart
Copy link
Member

reckart commented Oct 19, 2023

I didn't really review the changes - doesn't make sense when basically everything changes... good work!

@mawiesne
Copy link
Contributor Author

@reckart Will conduct an additional 4 eyes check with @rzo1 tmrw in the office. Perhaps you can checkout the branch and check things for naming consistency in a proper IDE of your choice.

@mawiesne mawiesne force-pushed the 165-switch-to-org.dkpro-style branch 2 times, most recently from 3ae4c55 to cd20ad2 Compare October 20, 2023 06:52
@mawiesne
#165 - Switch to "org.dkpro" style
c3024c4 
- relocates groupId to `org.dkpro.jwpl`
- relocates artifacts/modules to `dkpro-jwpl-XXX`
- moves src and test sources to new package namespace `org.dkpro.jwpl`
- adapts Spring's config / context files accordingly
- modernizes and fixes some (previously) broken javadoc
- repairs some inconsistent packages names in various files
@mawiesne mawiesne force-pushed the 165-switch-to-org.dkpro-style branch from cd20ad2 to c3024c4 Compare October 20, 2023 07:00
@rzo1 rzo1 merged commit 053adc9 into master Oct 20, 2023
@rzo1 rzo1 deleted the 165-switch-to-org.dkpro-style branch October 20, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckart reckart reckart approved these changes

@rzo1 rzo1 rzo1 approved these changes

Assignees

@mawiesne mawiesne

Labels
⚙️Refactoring
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mawiesne @reckart @rzo1