Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#178 - Provide method to retrieve a page's categories by page title #179

Conversation

mawiesne
Copy link
Contributor

  • Fixes this issue by introducing Set<Category> getCategories(String pageTitle) in Wikipedia
  • Adds new test cases to WikipediaTest to cover the new method
  • Sanitizes some JavaDoc in Category and Page

- Fixes this issue by introducing `Set<Category> getCategories(String pageTitle)` in Wikipedia
- Adds new test cases to `WikipediaTest` to cover the new method
- Sanitizes some JavaDoc in Category and Page
@mawiesne mawiesne added this to the 1.2.0 milestone Jul 16, 2018
@mawiesne mawiesne self-assigned this Jul 16, 2018
@mawiesne mawiesne requested review from reckart and daxenberger July 16, 2018 14:22
@ukp-svc-jenkins
Copy link

21% (+21.13%) vs master 0%

import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Star import :)

Copy link
Contributor Author

@mawiesne mawiesne Jul 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;) - I disabled the auto-optimization feature already.

@ukp-svc-jenkins
Copy link

22% (+0.34%) vs master 22%

…vide-method-to-retrieve-categories-by-page-title

* Conflicts:
*	de.tudarmstadt.ukp.wikipedia.api/src/main/java/de/tudarmstadt/ukp/wikipedia/api/Category.java
@ukp-svc-jenkins
Copy link

23% (+0.04%) vs master 23%

@mawiesne mawiesne merged commit 15d6d9f into master Jul 17, 2018
@mawiesne mawiesne deleted the enhancement/178-provide-method-to-retrieve-categories-by-page-title branch July 17, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants