dkpro-jwpl-hibernate-5.2.1-spring-4.3.0-migration #137
Conversation
- Hibernate 5.2.1.Final (it was: 4.1.3.Final) - Spring 4.3.0.RELEASE (it was: 3.1.1.RELEASE) applies necessary fixes that would break the code in WikiHibernateUtil removes deprecated warnings in several Hibernate bound classes related to Hibernate 4.x -> 5.x update updates some JDBC driver dependencies such as MySQL and PostgreSQL to more recent versions
|
Maybe it's worth releasing a '1.2.0' version to Maven central - in case the PR is acceptable for you. Don't hesitate to comment/ask me in case of any questions on my intention behind the proposed changes. |
|
+1 for this pull request! |
… want to use that at runtime and can't inject this config then... - adds a log4j entry to ignore warnings in JWPL as now C3P0 dependency is available at runtime
| @@ -1,6 +1,6 @@ | |||
| # Copyright 2016 | |||
| # Ubiquitous Knowledge Processing (UKP) Lab | |||
| # Technische Universit�t Darmstadt | |||
| # Technische Universit�t Darmstadt | |||
There was a problem hiding this comment.
no, seems the IDE screwed that one up. I'll fix that.
There was a problem hiding this comment.
Java properties files must be ISO 8859. Possibly the encoding in the repository was UTF-8 and the IDE tried to "fix" that.
|
Thanks a lot for the PR. We appreciate your interest and contributions very much. GitHub is a great place for you to build your open source contributor profile and we love to take new contributors on board. We have the policy of asking for a contributor license agreement. As your proposed changes are substantial and maybe you plan to contribute even more, I would ask you to please could carefully review our contribution policy and contributor license agreement: http://dkpro.github.io/contributing/ If you are able to send me a signed copy, I'll be more than happy to include your contributions into the codebase! |
fixes a mis-encoded umlaut character
|
@daxenberger - Just sent you a signed copy. |
|
Got it; thanks! |
provides changes that upgrade JWPL to use modern framework dependencies: