Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the icon package used #237

Closed
Aiky30 opened this issue Sep 8, 2021 · 2 comments
Closed

Document the icon package used #237

Aiky30 opened this issue Sep 8, 2021 · 2 comments

Comments

@Aiky30
Copy link
Contributor

Aiky30 commented Sep 8, 2021

Currently it' impossible to know where the icons came from in the project, to fix this the following information should be documented:

The icons are taken from Font Awesome 4. They can be found at the following url: https://github.com/FortAwesome/Font-Awesome/tree/v4.7.0

Examples of the icons to help choose: https://fontawesome.com/v4.7/icons/

The SVG's have been taken from here: https://github.com/Rush/Font-Awesome-SVG-PNG/tree/master/black/svg

@fsbraun
Copy link
Member

fsbraun commented Oct 3, 2022

We might want to consider putting the most common icons into the icon font django-cms core generates. That will be more efficient and allow for much easier and uniform changes in style since the icon color is not hard coded into the font.

Right now djangocms-admin-style pins the color scheme to light mode. Bare django admin will have an issue with dark icons in dark mode.

@fsbraun
Copy link
Member

fsbraun commented Jan 10, 2023

As of #302 versioning uses the icons of the core.

@fsbraun fsbraun closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants