Pre commit checks #517
Pre commit checks #517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 33 33
Branches 3 3
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. |
.pre-commit-config.yaml
Outdated
| @@ -9,34 +9,46 @@ ci: | |||
|
|
|||
| repos: | |||
| - repo: https://github.com/asottile/pyupgrade | |||
| rev: v3.15.0 | |||
| rev: v2.31.0 | |||
There was a problem hiding this comment.
Ok this highlights the need to upgrade the version in the repo where you've taken this code from as it's old.
| rev: v2.31.0 | |
| rev: v3.15.0 |
.pre-commit-config.yaml
Outdated
|
|
||
| - repo: https://github.com/adamchainz/django-upgrade | ||
| rev: '1.15.0' | ||
| rev: '1.4.0' |
There was a problem hiding this comment.
Keep an eye out for these, and if the version is lower on one repo, update it so that we are using the later versions everywhere. So what I'm seeing here makes it look like the pre-commit file in django-cms may need it's version upgrading.
| rev: '1.4.0' | |
| rev: '1.15.0' |
.pre-commit-config.yaml
Outdated
|
|
||
| - repo: https://github.com/asottile/yesqa | ||
| rev: v1.5.0 | ||
| rev: v1.3.0 |
There was a problem hiding this comment.
| rev: v1.3.0 | |
| rev: v1.5.0 |
.pre-commit-config.yaml
Outdated
| hooks: | ||
| - id: yesqa | ||
|
|
||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.5.0 | ||
| rev: v4.1.0 |
There was a problem hiding this comment.
| rev: v4.1.0 | |
| rev: v4.5.0 |
There was a problem hiding this comment.
I'm making these modify and upgrading also codespell and ruff-pre-commit
update pre-commit-config.yaml
add linter rules