-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Django 4.2 admin support #500
feat: Add Django 4.2 admin support #500
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 33 33
Branches 3 3
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. |
Hi @fsbraun , I will look into details and let you know if it fixes so we can merge and release new version of djangocms-admin-style |
@fsbraun , should it looks like that way? |
@DmytroLitvinov IMHO it should look like a form with editable fields, but the inputs replaced by the fields' values. Would you expect something else? |
For me it is fine that it looks like that way. Also attaching how it looks for [email protected] without djangocms-admin-style |
Yes, plain django admin style uses horizontal separation on large screens and vertical separation of label and field on small screens. @vinitkumar OK for you, too? Can you review? 😎 |
Django admin styles have changed. This fixes the delete-link styling and the readonly-fields styling