feat: Configurable dark mode (color scheme) #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Announce dark mode to the browser for scrollbar coloring
# Conflicts: # CHANGELOG.rst
Fix: deprecation warning for /
Fix: Leave more shadows dark in dark mode
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
Coverage 36.11% 36.11%
=======================================
Files 2 2
Lines 36 36
Branches 1 1
=======================================
Hits 13 13
Misses 23 23 Continue to review full report at Codecov.
|
5 tasks
fsbraun
changed the title
fsbraun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets the dark mode css be configured by django CMS settings and as proposed in PR django-cms/django-cms#7329.
It also overrides the dark mode settings of Django's admin styling to allow consistent light mode even with OS preferences set to dark mode.
Dark mode settings of django CMS are communicated through the
data-color-schemeattribute of the<html>element. If unset the os sets the color scheme. If setdata-color-scheme="light"the color scheme is light independently of the OS settings. Same is true for"dark".Know issue:
/admin) always shows in light mode since the django CMS configuration is not available to the Django admin app by default.