Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make web view fully asynchronous #87

Closed
snomos opened this issue Nov 13, 2023 · 1 comment
Closed

Make web view fully asynchronous #87

snomos opened this issue Nov 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@snomos
Copy link
Member

snomos commented Nov 13, 2023

The server client connection Is asynchronous, but the display is not. This means that the user has to wait for all responses to arrive before anything is displayed. This can take a long time for long documents.

Instead the grammar checker sidebar should update its view as the responses arrive. Some sort of feedback must be visible informing the user whether the grammar checking is finished or still pending, with an option to abort/stop the remaining checks.

If the user clicks "Check" to check the document anew before the old request is done, it should be automatically cancelled.

@snomos snomos added bug Something isn't working enhancement New feature or request labels Nov 13, 2023
@snomos
Copy link
Member Author

snomos commented Apr 29, 2024

We agreed that it is labour intesive (and thus expensive) to make the backend requests asyncronous at this time, so we should just show a spinner to let the user know that the plugin is checking the grammar.

Both GDocs and MS Word have spinners now (cf #49), so we can close this issue as won't fix.

@snomos snomos closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants